Re: [RFC PATCH] powerpc/spufs: fix copy_to_user while atomic

[Christoph Hellwig]

FYI, these little hunks reduce the difference to my version, maybe
you can fold them in?

diff --git a/arch/powerpc/platforms/cell/spufs/file.c 
b/arch/powerpc/platforms/cell/spufs/file.c
index c62d77ddaf7d3..1861436a6091d 100644
--- a/arch/powerpc/platforms/cell/spufs/file.c
+++ b/arch/powerpc/platforms/cell/spufs/file.c
@@ -2107,7 +2107,6 @@ static const struct file_operations spufs_wbox_info_fops 
= {
 static void ___spufs_dma_info_read(struct spu_context *ctx,
                struct spu_dma_info *info)
 {
-       struct mfc_cq_sr *qp, *spuqp;
        int i;
 
        info->dma_info_type = ctx->csa.priv2.spu_tag_status_query_RW;
@@ -2116,8 +2115,8 @@ static void ___spufs_dma_info_read(struct spu_context 
*ctx,
        info->dma_info_stall_and_notify = ctx->csa.spu_chnldata_RW[25];
        info->dma_info_atomic_command_status = ctx->csa.spu_chnldata_RW[27];
        for (i = 0; i < 16; i++) {
-               qp = &info->dma_info_command_data[i];
-               spuqp = &ctx->csa.priv2.spuq[i];
+               struct mfc_cq_sr *qp = &info->dma_info_command_data[i];
+               struct mfc_cq_sr *qp, *spuqp = &ctx->csa.priv2.spuq[i];
 
                qp->mfc_cq_data0_RW = spuqp->mfc_cq_data0_RW;
                qp->mfc_cq_data1_RW = spuqp->mfc_cq_data1_RW;
@@ -2166,7 +2165,7 @@ static const struct file_operations spufs_dma_info_fops = 
{
 };
 
 static void ___spufs_proxydma_info_read(struct spu_context *ctx,
-       struct spu_proxydma_info *info)
+               struct spu_proxydma_info *info)
 {
        int i;