On Tue, Oct 22, 2019 at 6:51 AM Ben Dooks (Codethink) <[email protected]> wrote: > > The table entry in __XDP_ACT_SYM_TAB for the last item is set > to { -1, 0 } where it should be { -1, NULL } as the second item > is a pointer to a string. > > Fixes the following sparse warnings: > > ./include/trace/events/xdp.h:28:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:53:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:82:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:140:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:155:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:190:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:225:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:260:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:318:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:356:1: warning: Using plain integer as NULL > pointer > ./include/trace/events/xdp.h:390:1: warning: Using plain integer as NULL > pointer > > Signed-off-by: Ben Dooks (Codethink) <[email protected]> > ---
Acked-by: Andrii Nakryiko <[email protected]> > Cc: Alexei Starovoitov <[email protected]> > Cc: Daniel Borkmann <[email protected]> > Cc: Martin KaFai Lau <[email protected]> > Cc: Song Liu <[email protected]> > Cc: Yonghong Song <[email protected]> > Cc: Steven Rostedt <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Jesper Dangaard Brouer <[email protected]> > Cc: John Fastabend <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > include/trace/events/xdp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h > index 8c8420230a10..c7e3c9c5bad3 100644 > --- a/include/trace/events/xdp.h > +++ b/include/trace/events/xdp.h > @@ -22,7 +22,7 @@ > #define __XDP_ACT_SYM_FN(x) \ > { XDP_##x, #x }, > #define __XDP_ACT_SYM_TAB \ > - __XDP_ACT_MAP(__XDP_ACT_SYM_FN) { -1, 0 } > + __XDP_ACT_MAP(__XDP_ACT_SYM_FN) { -1, NULL } > __XDP_ACT_MAP(__XDP_ACT_TP_FN) > > TRACE_EVENT(xdp_exception, > -- > 2.23.0 >
