On Sun, Oct 20, 2019 at 07:42:15PM -0700, Florian Fainelli wrote: > > > On 10/19/2019 8:19 PM, Vivien Didelot wrote: > > Use the new ports list instead of iterating over switches and their > > ports when setting up the switches and their ports. > > > > At the same time, provide setup states and messages for ports and > > switches as it is done for the trees. > > Humm, that becomes quite noisy, would it make sense to have those > messages only for non-user ports that are not already visible because > they do not have a net_device?
I agree, it looks noise. Maybe change them to _dbg()? > If you have multiple switches in a fabric, it might be convenient to use > dev_info(dp->ds->dev, ...) to print your message so you can clearly > identify which port belongs to which switch, which becomes even more > important as it is all flattened thanks to lists now. What do you think? I do think it needs to identify both the dst and the ds. Andrew
