On 17-10-19, 21:55, John Hubbard wrote:
> The following build warning occurred on powerpc 64-bit builds:
>
> drivers/cpufreq/powernv-cpufreq.c: In function 'init_chip_info':
> drivers/cpufreq/powernv-cpufreq.c:1070:1: warning: the frame size of 1040
> bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> This is due to putting 1024 bytes on the stack:
>
> unsigned int chip[256];
>
> ...and while looking at this, it also has a bug: it fails with a stack
> overrun, if CONFIG_NR_CPUS > 256.
>
> Fix both problems by dynamically allocating based on CONFIG_NR_CPUS.
>
> Fixes: 053819e0bf840 ("cpufreq: powernv: Handle throttling due to Pmax
> capping at chip level")
> Cc: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com>
> Cc: Preeti U Murthy <pre...@linux.vnet.ibm.com>
> Cc: Viresh Kumar <viresh.ku...@linaro.org>
> Cc: Rafael J. Wysocki <r...@rjwysocki.net>
> Cc: linux...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org
> Signed-off-by: John Hubbard <jhubb...@nvidia.com>
> ---
>
> Changes since v1: includes Viresh's review commit fixes.
>
> drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
--
viresh
