On Wed, Oct 02, 2019 at 06:28:59AM +0000, Atish Patra wrote: > On Wed, 2019-10-02 at 09:53 +0800, Alan Kao wrote: > > On Tue, Oct 01, 2019 at 03:10:16AM -0700, h...@infradead.org wrote: > > > On Tue, Oct 01, 2019 at 08:22:37AM +0000, Atish Patra wrote: > > > > riscv_of_processor_hartid() or seems to be a better candidate. We > > > > already check if "rv" is present in isa string or not. I will > > > > extend > > > > that to check for rv64i or rv32i. Is that okay ? > > > > > > I'd rather lift the checks out of that into a function that is > > > called > > > exactly once per hart on boot (and future cpu hotplug). > > > @Christoph > Do you mean to lift the checks for "rv" as well from > riscv_of_processor_hartid as well or leave that as it is?
Sounds good to me (as a separate patch). Again it makes much more sense to validate this once early at boot time rather than a function that can be called many tims during run time.
