Hi Dmitry, I love your patch! Yet something to improve:
[auto build test ERROR on regulator/for-next] [cannot apply to v5.4-rc1 next-20191004] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/regulator-switch-to-using-devm_-fwnode_gpiod_get_index/20191005-085020 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All error/warnings (new ones prefixed by >>): drivers/regulator/slg51000-regulator.c: In function 'slg51000_of_parse_cb': >> drivers/regulator/slg51000-regulator.c:203:14: error: implicit declaration >> of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? >> [-Werror=implicit-function-declaration] ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0, ^~~~~~~~~~~~~~~~~~~~~~ devm_gpiod_get_index >> drivers/regulator/slg51000-regulator.c:203:12: warning: assignment makes >> pointer from integer without a cast [-Wint-conversion] ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0, ^ cc1: some warnings being treated as errors vim +203 drivers/regulator/slg51000-regulator.c 196 197 static int slg51000_of_parse_cb(struct device_node *np, 198 const struct regulator_desc *desc, 199 struct regulator_config *config) 200 { 201 struct gpio_desc *ena_gpiod; 202 > 203 ena_gpiod = fwnode_gpiod_get_index(of_fwnode_handle(np), > "enable", 0, 204 GPIOD_OUT_LOW | 205 GPIOD_FLAGS_BIT_NONEXCLUSIVE, 206 "gpio-en-ldo"); 207 if (!IS_ERR(ena_gpiod)) 208 config->ena_gpiod = ena_gpiod; 209 210 return 0; 211 } 212 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
