On 01/10/2019 14:36:55+0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2019 at 10:08:09PM +0200, Alexandre Belloni wrote: > > > > Maybe be rtc_str should take a struct tm instead of an rtc_time so > > > > time64_to_rtc_time always uses time64_to_tm. > > > > > > Because this one, while sounding plausible, maybe too invasive on current > > > state of affairs. > > > > Well, if the kernel struct tm had an int tm_year instead of long > > tm_year, then you could simply cast a struct rtc_time to a struct tm. > > I don't think so. It will be error prone from endianess prospective on > 64-bit platforms. >
I don't get why, as long as the first members of both structs are the same, this should work. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
