> -----Original Message----- > From: Tal Gilboa <ta...@mellanox.com> > Sent: Friday, September 20, 2019 8:02 PM > To: Uwe Kleine-König <u...@kleine-koenig.org>; Saeed Mahameed > <sae...@mellanox.com>; Kiyanovski, Arthur <akiy...@amazon.com> > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol > > On 9/20/2019 4:31 PM, Uwe Kleine-König wrote: > > According to Tal Gilboa the only benefit from DIM comes from a driver > > that uses it. So it doesn't make sense to make this symbol user visible, > > instead all drivers that use it should select it (as is already the case > > AFAICT). > > > > Signed-off-by: Uwe Kleine-König <u...@kleine-koenig.org> > > --- > > lib/Kconfig | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/lib/Kconfig b/lib/Kconfig > > index cc04124ed8f7..9fe8a21fd183 100644 > > --- a/lib/Kconfig > > +++ b/lib/Kconfig > > @@ -555,8 +555,7 @@ config SIGNATURE > > Implementation is done using GnuPG MPI library > > > > config DIMLIB > > - bool "DIM library" > > - default y > > + bool > > help > > Dynamic Interrupt Moderation library. > > Implements an algorithm for dynamically change CQ moderation > values > > > There's a pending series using DIM which didn't add the select clause > [1]. Arthur, FYI. Other than that LGTM. > > [1] https://www.mail-archive.com/netdev@vger.kernel.org/msg314304.html
Thanks Tal, I missed that.
