[PATCH v2 2/5] leds: lm3692x: Don't overwrite return value in error path

[Guido Günther]

The driver currently reports successful initialization on every failure
as long as it's able to power off the regulator. Don't check the return
value of regulator_disable to avoid that.

Signed-off-by: Guido Günther <a...@sigxcpu.org>
---
 drivers/leds/leds-lm3692x.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 487228c2bed2..31115655f97b 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -198,7 +198,7 @@ static int lm3692x_brightness_set(struct led_classdev 
*led_cdev,
 static int lm3692x_init(struct lm3692x_led *led)
 {
        int enable_state;
-       int ret;
+       int ret, ret2;
 
        if (led->regulator) {
                ret = regulator_enable(led->regulator);
@@ -313,14 +313,15 @@ static int lm3692x_init(struct lm3692x_led *led)
                gpiod_direction_output(led->enable_gpio, 0);
 
        if (led->regulator) {
-               ret = regulator_disable(led->regulator);
-               if (ret)
+               ret2 = regulator_disable(led->regulator);
+               if (ret2)
                        dev_err(&led->client->dev,
                                "Failed to disable regulator\n");
        }
 
        return ret;
 }
+
 static int lm3692x_probe_dt(struct lm3692x_led *led)
 {
        struct fwnode_handle *child = NULL;
-- 
2.23.0.rc1