On Thu, 15 Aug 2019, Luck, Tony wrote: > On Thu, Aug 15, 2019 at 07:54:55PM +0200, Borislav Petkov wrote: > @@ -11,6 +11,21 @@ > * While adding a new CPUID for a new microarchitecture, add a new > * group to keep logically sorted out in chronological order. Within > * that group keep the CPUID for the variants sorted by model number. > + * > + * HOWTO Build an INTEL_FAM6_ definition: > + * > + * 1. Start with INTEL_FAM6_ > + * 2. If not Core-family, add a note about it, like "ATOM". There are only > + * two options for this (Xeon Phi and Atom). It is exceedingly unlikely > + * that you are adding a cpu which needs a new option here. > + * 3. Add the processor microarchitecture, not the platform name > + * 4. Add a short differentiator if necessary. Add an _X to differentiate > + * Server from Client.
We have the following existing _SHORT variants: _G _EP _EX _CORE _ULT _GT3E _XEON_D _MOBILE _DESKTOP _NNPI _MID _TABLET _PLUS So we should document the list of valid and usable ones and either fixup broken ones or document that they are historic ballast and not to be used for new ones. Otherwise you end up with the same discussions again. Thanks, tglx