Hi Colin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4 next-20190814]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Colin-King/scsi-mvumi-fix-32-bit-shift-of-a-u32-value/20190814-214025
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/mvumi.c: In function 'mvumi_delete_internal_cmd':
>> drivers/scsi/mvumi.c:299:38: warning: left shift count >= width of type 
>> [-Wshift-count-overflow]
           (dma_addr_t) m_sg->baseaddr_h << 32;
                                         ^~

vim +299 drivers/scsi/mvumi.c

   285  
   286  static void mvumi_delete_internal_cmd(struct mvumi_hba *mhba,
   287                                                  struct mvumi_cmd *cmd)
   288  {
   289          struct mvumi_sgl *m_sg;
   290          unsigned int size;
   291          dma_addr_t phy_addr;
   292  
   293          if (cmd && cmd->frame) {
   294                  if (cmd->frame->sg_counts) {
   295                          m_sg = (struct mvumi_sgl *) 
&cmd->frame->payload[0];
   296                          sgd_getsz(mhba, m_sg, size);
   297  
   298                          phy_addr = (dma_addr_t) m_sg->baseaddr_l |
 > 299                                     (dma_addr_t) m_sg->baseaddr_h << 32;
   300  
   301                          dma_free_coherent(&mhba->pdev->dev, size, 
cmd->data_buf,
   302                                                                  
phy_addr);
   303                  }
   304                  dma_free_coherent(&mhba->pdev->dev, mhba->ib_max_size,
   305                                  cmd->frame, cmd->frame_phys);
   306                  kfree(cmd);
   307          }
   308  }
   309  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to