On Mon, 2019-07-29 at 20:42 -0700, Palmer Dabbelt wrote: > On Fri, 26 Jul 2019 15:20:47 PDT (-0700), Atish Patra wrote: > > On 7/26/19 1:47 PM, Paul Walmsley wrote: > > > On Fri, 26 Jul 2019, Atish Patra wrote: > > > > > > > As per riscv specification, ISA naming strings are > > > > case insensitive. However, currently only lower case > > > > strings are parsed during cpu procfs. > > > > > > > > Support parsing of upper case letters as well. > > > > > > > > Signed-off-by: Atish Patra <atish.pa...@wdc.com> > > > > > > Is there a use case that's driving this, or > > > > Currently, we use all lower case isa string in kvmtool. But > > somebody can > > have uppercase letters in future as spec allows it. > > > > > > can we just say, "use > > > lowercase letters" and leave it at that? > > > > > > > In that case, it will not comply with RISC-V spec. Is that okay ? > > We could make the platform spec say "use lowercase letters" and wipe > our hands > of it -- IIRC we still only support the lower case letters in GCC due > to > multilib headaches, so it's kind of the de-facto standard already. >
Sounds good. That's what I suggested in earlier email as well. It would be good to add "use lowercase letters" in yaml documentation as well just to avoid any confusion at all. I will send a v2 soon. Regards, Atish > > > - Paul > > >
