Static analysis identified that index comparison against ITS entries in
iort_dev_find_its_id() is off by one.
Update the comparison condition and clarify the resulting error
message.
Fixes: 4bf2efd26d76 ("ACPI: Add new IORT functions to support MSI domain
handling")
Link: https://lore.kernel.org/linux-arm-kernel/20190613065410.GB16334@mwanda/
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com>
Cc: Dan Carpenter <dan.carpen...@oracle.com>
Cc: Will Deacon <w...@kernel.org>
Cc: Hanjun Guo <guohan...@huawei.com>
Cc: Sudeep Holla <sudeep.ho...@arm.com>
Cc: Catalin Marinas <catalin.mari...@arm.com>
Cc: Robin Murphy <robin.mur...@arm.com>
---
drivers/acpi/arm64/iort.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 15dbfd657d82..5a7551d060f2 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -611,8 +611,8 @@ static int iort_dev_find_its_id(struct device *dev, u32
req_id,
/* Move to ITS specific data */
its = (struct acpi_iort_its_group *)node->node_data;
- if (idx > its->its_count) {
- dev_err(dev, "requested ITS ID index [%d] is greater than
available [%d]\n",
+ if (idx >= its->its_count) {
+ dev_err(dev, "requested ITS ID index [%d] overruns ITS entries
[%d]\n",
idx, its->its_count);
return -ENXIO;
}
--
2.21.0
