On Sat, 13 Jul 2019 at 05:48, Wen Yang <wen.yan...@zte.com.cn> wrote:
>
> The cpu_dai variable is still being used after the of_node_put() call,
> which may result in double-free:
>
> of_node_put(cpu_dai); ---> released here
>
> ret = devm_snd_soc_register_card(dev, card);
> if (ret < 0) {
> ...
> goto err_put_clk_i2s; --> jump to err_put_clk_i2s
> ...
>
> err_put_clk_i2s:
> clk_put(priv->clk_i2s_bus);
> err_put_sclk:
> clk_put(priv->sclk_i2s);
> err_put_cpu_dai:
> of_node_put(cpu_dai); --> double-free here
>
> Fixes: d832d2b246c5 ("ASoC: samsung: odroid: Fix of_node refcount unbalance")
> Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
> Cc: Krzysztof Kozlowski <k...@kernel.org>
> Cc: Sangbeom Kim <sbki...@samsung.com>
> Cc: Sylwester Nawrocki <s.nawro...@samsung.com>
> Cc: Liam Girdwood <lgirdw...@gmail.com>
> Cc: Mark Brown <broo...@kernel.org>
> Cc: Jaroslav Kysela <pe...@perex.cz>
> Cc: Takashi Iwai <ti...@suse.com>
> Cc: alsa-de...@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> ---
> sound/soc/samsung/odroid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <k...@kernel.org>
Best regards,
Krzysztof
