This patch fixes a potential null dereference bug where we dereference us 
before a null check. This patch simply moves the dereferencing after the null 
check.

Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---

--- a/drivers/usb/storage/shuttle_usbat.c
+++ b/drivers/usb/storage/shuttle_usbat.c
@@ -187,12 +187,14 @@
  */
 static int usbat_check_status(struct us_data *us)
 {
-       unsigned char *reply = us->iobuf;
+       unsigned char *reply;
        int rc;
 
        if (!us)
                return USB_STOR_TRANSPORT_ERROR;
 
+       reply = us->iobuf;
+
        rc = usbat_get_status(us, reply);
        if (rc != USB_STOR_XFER_GOOD)
                return USB_STOR_TRANSPORT_FAILED;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to