tir, 04 09 2007 kl. 13:06 +0200, skrev Jens Axboe:
> On Tue, Sep 04 2007, Micah Gruber wrote:
> > This patch fixes a potential null dereference bug where we dereference us
> > before a null check. This patch simply moves the dereferencing after the
> > null check.
> >
> > Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
>
> Be careful with stuff like that, if you actually look at the code, a us
> == NULL doesn't seem to be possible (or usbat_flash_transport() would
> have oopsed before).
>
If that is true, then
if (!us)
return USB_STOR_TRANSPORT_ERROR;
is utterly pointless.
Simon Holm Thøgersen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
