On 6/30/19 9:58 PM, Hanjun Guo wrote:
On 2019/5/26 20:50, Alexandre Ghiti wrote:
ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures:
move this declaration in arch/Kconfig and make those architectures
select it.

Signed-off-by: Alexandre Ghiti <a...@ghiti.fr>
Reviewed-by: Palmer Dabbelt <pal...@sifive.com>
---
  arch/Kconfig       | 3 +++
  arch/arm64/Kconfig | 2 +-
  arch/x86/Kconfig   | 4 +---
  3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index c47b328eada0..d2f212dc8e72 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -577,6 +577,9 @@ config HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
  config HAVE_ARCH_HUGE_VMAP
        bool
+config ARCH_WANT_HUGE_PMD_SHARE
+       bool
+
  config HAVE_ARCH_SOFT_DIRTY
        bool
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 4780eb7af842..dee7f750c42f 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -70,6 +70,7 @@ config ARM64
        select ARCH_SUPPORTS_NUMA_BALANCING
        select ARCH_WANT_COMPAT_IPC_PARSE_VERSION
        select ARCH_WANT_FRAME_POINTERS
+       select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES 
&& !ARM64_VA_BITS_36)
        select ARCH_HAS_UBSAN_SANITIZE_ALL
        select ARM_AMBA
        select ARM_ARCH_TIMER
@@ -884,7 +885,6 @@ config SYS_SUPPORTS_HUGETLBFS
        def_bool y
config ARCH_WANT_HUGE_PMD_SHARE
-       def_bool y if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
Why not remove config ARCH_WANT_HUGE_PMD_SHARE as well?
Did I miss something?

You're totally right ! Thanks for noticing,

Alex

Thanks
Hanjun

Reply via email to