On Tue, Jun 25, 2019 at 6:33 PM Tri Vo <tr...@android.com> wrote: > > On Tue, Jun 25, 2019 at 6:12 PM Greg KH <gre...@linuxfoundation.org> wrote: > > > > On Tue, Jun 25, 2019 at 05:54:49PM -0700, Tri Vo wrote: > > > Embedding a struct kobject into struct wakeup_source changes lifetime > > > requirements on the latter. To that end, change deallocation of struct > > > wakeup_source using kfree to kobject_put(). > > > > Ick, are you sure you need a new kobject here? Why wouldn't a named > > attribute group work instead? That should keep this patch much smaller > > and simpler. > > Yeah, named attribute groups might be a much cleaner way to do this. > Let me investigate.
Say, we read /sys/power/wakeup_sources/foo/active_count. This attribute's show function needs to find wakeup_source struct of "foo". I'm not sure how to do that without embedding a kobject inside of wakeup_source.
