Re: [PATCH net-next] hinic: implement the statistical interface of ethtool

[David Miller]

From: Xue Chaojing <xuechaoj...@huawei.com>
Date: Thu, 20 Jun 2019 05:58:08 +0000

> +                     p = (char *)(&txq_stats) +
> +                             hinic_tx_queue_stats[j].offset;

Parenthesis around &txq_stats is unnecessary.

> +                     p = (char *)(&rxq_stats) +
> +                             hinic_rx_queue_stats[j].offset;

Similarly for &rxq_stats.

> +             p = (char *)(net_stats) + hinic_netdev_stats[j].offset;

Similarly for net_stats.

> +             p = (char *)(&vport_stats) + hinic_function_stats[j].offset;

And &vport_stats.

> +             p = (char *)(port_stats) + hinic_port_stats[j].offset;

And port_stats.