Hi, Fabio
> -----Original Message-----
> From: Fabio Estevam <[email protected]>
> Sent: Friday, May 31, 2019 7:40 PM
> To: Anson Huang <[email protected]>
> Cc: Rob Herring <[email protected]>; Mark Rutland
> <[email protected]>; Shawn Guo <[email protected]>; Sascha
> Hauer <[email protected]>; Sascha Hauer <[email protected]>;
> Andrey Smirnov <[email protected]>; Manivannan Sadhasivam
> <[email protected]>; Bruno Thomsen
> <[email protected]>; Aisheng Dong <[email protected]>;
> Jacky Bai <[email protected]>; Leo Li <[email protected]>; Lucas Stach
> <[email protected]>; Pankaj Bansal <[email protected]>;
> Bhaskar Upadhaya <[email protected]>; Pramod Kumar
> <[email protected]>; Vabhav Sharma <[email protected]>;
> Leonard Crestez <[email protected]>; open list:OPEN FIRMWARE
> AND FLATTENED DEVICE TREE BINDINGS <[email protected]>;
> linux-kernel <[email protected]>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <[email protected]>; dl-
> linux-imx <[email protected]>
> Subject: Re: [PATCH 2/3] arm64: dts: freescale: Add i.MX8MN dtsi support
>
> On Thu, May 30, 2019 at 6:45 AM <[email protected]> wrote:
>
> > + gpio1: gpio@30200000 {
> > + compatible = "fsl,imx8mn-gpio",
> > "fsl,imx35-gpio";
> > + reg = <0x30200000 0x10000>;
> > + interrupts = <GIC_SPI 64
> > IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 65
> > + IRQ_TYPE_LEVEL_HIGH>;
>
> No GPIO clocks entries?
Just noticed this, the internal bring-up branch's clock driver does NOT have it,
I will add them in V2, thanks for pointing out this.
>
> > + usbphynop1: usbphynop1 {
> > + compatible = "usb-nop-xceiv";
> > + clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
> > + assigned-clocks = <&clk
> > IMX8MN_CLK_USB_PHY_REF>;
> > + assigned-clock-parents = <&clk
> IMX8MN_SYS_PLL1_100M>;
> > + clock-names = "main_clk";
> > + };
>
> usbphynop1 does not have any registers associated, so it should be placed
> outside the soc.
>
> Building with W=1 should warn you about that.
>
OK, I will move them to outside of soc.
> > + usbphynop2: usbphynop2 {
> > + compatible = "usb-nop-xceiv";
> > + clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
> > + assigned-clocks = <&clk
> > IMX8MN_CLK_USB_PHY_REF>;
> > + assigned-clock-parents = <&clk
> IMX8MN_SYS_PLL1_100M>;
> > + clock-names = "main_clk";
> > + };
> > +
>
> Ditto
OK, I will move them to outside of soc.
Thanks,
Anson.
