On Thu, May 23, 2019 at 01:41:21PM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang <kan.li...@linux.intel.com> > > The "sibling cores" actually shows the sibling CPUs of a socket. > The name "sibling cores" is very misleading. > > Rename "sibling cores" to "sibling sockets"
by checking on die topology, I found that thread_siblings_list is deprecated/renamed to core_cpus_list.. we should keep that in mind and support both jirka > > Signed-off-by: Kan Liang <kan.li...@linux.intel.com> > --- > tools/perf/Documentation/perf.data-file-format.txt | 2 +- > tools/perf/util/header.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Documentation/perf.data-file-format.txt > b/tools/perf/Documentation/perf.data-file-format.txt > index c731416..dd85163 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -168,7 +168,7 @@ struct { > }; > > Example: > - sibling cores : 0-8 > + sibling sockets : 0-8 > sibling dies : 0-3 > sibling dies : 4-7 > sibling threads : 0-1 > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index faa1e38..eb79495 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -1465,7 +1465,7 @@ static void print_cpu_topology(struct feat_fd *ff, FILE > *fp) > str = ph->env.sibling_cores; > > for (i = 0; i < nr; i++) { > - fprintf(fp, "# sibling cores : %s\n", str); > + fprintf(fp, "# sibling sockets : %s\n", str); > str += strlen(str) + 1; > } > > -- > 2.7.4 >