On Tue, May 14, 2019 at 9:01 AM Joe Perches <j...@perches.com> wrote: > > On Tue, 2019-05-14 at 08:46 +0900, Masahiro Yamada wrote: > > So, I think these two checks can be done for > > all file types. > [] > > checkpatch.pl misses to report most of them. > > (the majority of the warning source is *.json) > > Perhaps the json files should be ignored as more than > half of the .json files in the tree are missing the > newline at EOF.
I guess they are accident. I do not think missing newline in *.json is syntactically significant. If we are unsure, it is better to ask the maintainers. > And at least some of those json files use spaces for > indentation and not tabs. This is different stuff. Indentation and newline at EOF are not linked. -- Best Regards Masahiro Yamada
