Re: [PATCH] afs: remove redundant assignment to variable ret

[David Howells]

Joe Perches <j...@perches.com> wrote:

> @@ -71,11 +71,9 @@ static int afs_xattr_get_acl(const struct xattr_handler 
> *handler,
>       if (ret == 0) {
>               ret = acl->size;
>               if (size > 0) {
> -                     ret = -ERANGE;
>                       if (acl->size > size)
>                               return -ERANGE;
>                       memcpy(buffer, acl->data, acl->size);
> -                     ret = acl->size;
>               }
>               kfree(acl);
>       }

This is also the wrong solution.  See my reply to Colin.

David