On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote: > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > + > > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf, > > + size_t bytes, loff_t offset) > > +{ > > + const size_t chunk_size = ctrl->max_hw_sectors * ctrl->page_size; > > Just curious if chunk_size is correct since page size and block size can > be different.
They're always different. ctrl->page_size is hard-coded to 4k, while sectors are always 512b.