Hi, Lee, Thanks for review, my replies are inline: Signed-off-by: Morris Ku <sau...@gmail.com> --- + +On 03 Apr 2019, Lee Jones wrote: + +> >Please do not drop the list from your recipients. + +>On Tue, 02 Apr 2019, Morris Ku ????????? wrote: + +> Hello , Lee , +> +> +> Sunix multi-io card is a composite device, +> contains serial and parallel port , before we +> trying to place the driver in the /drivers/char, +> but maintainer suggests go to /driver/mfd,so we move to here. +> this driver is special,it supports more than one interface, +> so we combine to a single driver. + +> The MFD subsystem is designed to register child devices. MFD drivers +> do not contain any true functionality themselves. If this device does +> multiple things, you can split the functionality into their relevant +> subsystems and register each of them from here. + +> There are 10's of examples available. Please take a look around some +> of the existing drivers to see how their functionality is split. +
Could you please clearly tell me the name of driver for reference. + +> On Tue, 19 Mar 2019, Morris Ku wrote: +> +> > Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c +> > and lp.c by Linus Torvalds, Theodore Ts'o. +> +> Parallel port drivers should live in 'drivers/parport' and +> 'drivers/char'. LP drivers should live in 'drivers/char'. +> +> Please them there. +> +> > Signed-off-by: Morris Ku <sau...@gmail.com> +> > --- +> > mfd/sunix/snx_ieee1284.c | 144 +++++++ +> > mfd/sunix/snx_ieee1284_ops.c | 258 +++++++++++++ +> > mfd/sunix/snx_lp.c | 717 +++++++++++++++++++++++++++++++++++ +> > mfd/sunix/snx_lp.h | 119 ++++++ +> > mfd/sunix/snx_parallel.c | 397 +++++++++++++++++++ +> > mfd/sunix/snx_ppdev.c | 454 ++++++++++++++++++++++ +> > mfd/sunix/snx_ppdev.h | 15 + +> > mfd/sunix/snx_share.c | 629 ++++++++++++++++++++++++++++++ +> > 8 files changed, 2733 insertions(+) +> > create mode 100644 mfd/sunix/snx_ieee1284.c +> > create mode 100644 mfd/sunix/snx_ieee1284_ops.c +> > create mode 100644 mfd/sunix/snx_lp.c +> > create mode 100644 mfd/sunix/snx_lp.h +> > create mode 100644 mfd/sunix/snx_parallel.c +> > create mode 100644 mfd/sunix/snx_ppdev.c +> > create mode 100644 mfd/sunix/snx_ppdev.h +> > create mode 100644 mfd/sunix/snx_share.c +> + -- 2.17.1
