Em Wed, Apr 03, 2019 at 04:37:38PM +0200, Jiri Olsa escreveu:
> hi,
> perf script --call-trace stop working for me recently,
> and displays only user space functions
>
> I bisected that to:
> 7b612e291a5a perf tools: Synthesize PERF_RECORD_* for loaded BPF programs
>
> data from following comands will display user space functions only:
> # perf-with-kcore record pt -e intel_pt// -- ls
> # perf-with-kcore script pt --call-trace
>
> when I disable the bpf synthesizing (patch below), kernel functions are back
>
> I guess the new events mess up with intel_pt decoder somehow
And also that synthesizing should't take place when we use
perf record --no-bpf-event
I.e. I'm adding the patch below to my perf/urgent branch.
The --no-bpf-event option was put in place exactly for that for
explicitely disabling it if one thinks it is messing with something,
like seems to be the case here.
- Arnaldo
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 4e2d953d4bc5..17d772f192ad 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1114,10 +1114,11 @@ static int record__synthesize(struct record *rec, bool
tail)
return err;
}
- err = perf_event__synthesize_bpf_events(session,
process_synthesized_event,
- machine, opts);
- if (err < 0)
- pr_warning("Couldn't synthesize bpf events.\n");
+ if (!opts->no_bpf_event) {
+ err = perf_event__synthesize_bpf_events(session,
process_synthesized_event, machine, opts);
+ if (err < 0)
+ pr_warning("Couldn't synthesize bpf events.\n");
+ }
err = __machine__synthesize_threads(machine, tool, &opts->target,
rec->evlist->threads,
process_synthesized_event,
opts->sample_address,
>
> thanks,
> jirka
>
>
> ---
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 4e2d953d4bc5..3daa78bc6549 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -1114,10 +1114,12 @@ static int record__synthesize(struct record *rec,
> bool tail)
> return err;
> }
>
> +#if 0
> err = perf_event__synthesize_bpf_events(session,
> process_synthesized_event,
> machine, opts);
> if (err < 0)
> pr_warning("Couldn't synthesize bpf events.\n");
> +#endif
>
> err = __machine__synthesize_threads(machine, tool, &opts->target,
> rec->evlist->threads,
> process_synthesized_event,
> opts->sample_address,
--
- Arnaldo
