On Wed, Mar 27, 2019 at 12:49 PM Stefan Hajnoczi <stefa...@redhat.com> wrote:
> Which field was accessed before initialization? > > I ask because the situation is now unclear since code remains that > assumes vsock is *not* zero-initialized: > > vsock->guest_cid = 0; /* no CID assigned yet */ > > atomic_set(&vsock->queued_replies, 0); It was hash. > If we're going to zalloc, let's get rid of explicit zero > initializations. Or let's use kvmalloc() and fix the uninitialized > access. Mixing both is confusing. I would go with zalloc, since it's easier to read and it prevents further situations like this. A zalloc was there originally (not in fallback though).
