On Thu, Mar 21, 2019 at 01:42:25PM +0100, Arnd Bergmann wrote:
> The newly added tracepoints in the spi-mxs driver cause a link
> error when the driver is a loadable module:
>
> ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
> ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
>
> I'm not quite sure where to put the export statements, but
> directly after the inclusion of the header seems as good as
> any other place.
I agree it looks a bit ugly, but I don't have a better idea either.
>
> Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message
> callback")
> Signed-off-by: Arnd Bergmann <[email protected]>
Looks right:
Acked-by: Uwe Kleine-König <[email protected]>
Thanks for finding and fixing that.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
