> Although I'm thinking of: > > static bool __attribute_const__ > is_aligned(const void *base, size_t size, unsigned char align) > { > unsigned char lsbits = (unsigned char)size; > > (void)base; > #ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > lsbits |= (unsigned char)(uintptr_t)base; > #endif > return (lsbits & (align - 1)) == 0; > } > > Any preference? I think it would be better.
> I find "u32s" confusing; I keep reading the "s" as "signed" rather than a > plural. How about one of: swap_bytes / swap_ints / swap_longs swap_1 / swap_4 > / swap_8 In my opinion "swap_bytes / swap_ints / swap_longs" are the most readable. (Good job)