On Tue, Mar 05, 2019 at 07:33:56PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired > a node pointer with refcount incremented on line 57, but without a > corresponding object release within this function. > > Signed-off-by: Wen Yang <wen.yan...@zte.com.cn> > Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > Cc: Russell King <li...@armlinux.org.uk> > Cc: Shawn Guo <shawn...@kernel.org> > Cc: Sascha Hauer <s.ha...@pengutronix.de> > Cc: Pengutronix Kernel Team <ker...@pengutronix.de> > Cc: Fabio Estevam <feste...@gmail.com> > Cc: NXP Linux Team <linux-...@nxp.com> > Cc: Lucas Stach <l.st...@pengutronix.de> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > v2->v1: add a missing space between "adding" and "missing"
I fixed it against v1 which I applied on my branch. Shawn