On Tue, Aug 07, 2007 at 10:16:03PM +0200, Olaf Hering wrote: > remove linux/binfmts.h from make headers_install > > A recent patch added PAGE_SIZE to the part outside of __KERNEL__. > qemu and ia32el have their own define of MAX_ARG_PAGES.
Should they use kernel header instead? > No package uses linux/binfmts.h, so it is safe to not provide it. And? Does it contain stuff which is userspace visible? binfmts.h has at least CORENAME_MAX_SIZE and SUID_DUMP_* "userspace doesn't use header" is something headers_install has never been about. > --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -173,7 +173,6 @@ unifdef-y += atm.h > unifdef-y += atm_tcp.h > unifdef-y += audit.h > unifdef-y += auto_fs.h > -unifdef-y += binfmts.h > unifdef-y += capability.h > unifdef-y += capi.h > unifdef-y += cciss_ioctl.h > --- a/include/linux/binfmts.h > +++ b/include/linux/binfmts.h > @@ -17,7 +17,6 @@ struct pt_regs; > /* sizeof(linux_binprm->buf) */ > #define BINPRM_BUF_SIZE 128 > > -#ifdef __KERNEL__ > > #define CORENAME_MAX_SIZE 128 > > @@ -99,5 +98,4 @@ extern void compute_creds(struct linux_b > extern int do_coredump(long signr, int exit_code, struct pt_regs * regs); > extern int set_binfmt(struct linux_binfmt *new); > > -#endif /* __KERNEL__ */ > #endif /* _LINUX_BINFMTS_H */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/