Hello, On Wed, 16 Jan 2019 15:48:29 +0100, Andrew Lunn wrote:
> Reviewed-by: Andrew Lunn <and...@lunn.ch> > > However, i wounder if it makes sense to add a label before the > existing device_del() at the end of the function, and convert this, > and the case above into a goto? That might scale better, avoiding the > same issue in the future? That's another option indeed. Hmm, now that I looked at it, I think we should use device_unregister() instead. device_unregister() does both device_del() and put_device(). According to the comment above device_register(), put_device() should always be called: "Always use put_device() to give up the reference initialized in this function instead.". What do you think? Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
