On Wed, Jan 16, 2019 at 04:18:55PM +0100, Thomas Petazzoni wrote: > Hello, > > On Wed, 16 Jan 2019 15:48:29 +0100, Andrew Lunn wrote: > > > Reviewed-by: Andrew Lunn <and...@lunn.ch> > > > > However, i wounder if it makes sense to add a label before the > > existing device_del() at the end of the function, and convert this, > > and the case above into a goto? That might scale better, avoiding the > > same issue in the future? > > That's another option indeed. > > Hmm, now that I looked at it, I think we should use device_unregister() > instead. device_unregister() does both device_del() and put_device().
Hi Thomas device_unregister() does seem symmetrical with device_register() which is what we are trying to undo. Andrew
