On Sun, Jan 13, 2019 at 01:36:44PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/mfd/Kconfig:config MFD_WM831X_SPI > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with > SPI" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Lee Jones <lee.jo...@linaro.org> > Cc: patc...@opensource.cirrus.com > Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> > Acked-by: Linus Walleij <linus.wall...@linaro.org> > ---
Acked-by: Charles Keepax <ckee...@opensource.cirrus.com> Thanks, Charles