Hi Jason, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/lib-scatterlist-Provide-a-DMA-page-iterator/20190105-081739 config: x86_64-randconfig-x017-201900 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file included from lib/scatterlist.c:9:0: >> include/linux/export.h:81:20: error: redefinition of >> '__kstrtab___sg_page_iter_next' static const char __kstrtab_##sym[] \ ^ include/linux/export.h:120:25: note: in expansion of macro '___EXPORT_SYMBOL' #define __EXPORT_SYMBOL ___EXPORT_SYMBOL ^~~~~~~~~~~~~~~~ include/linux/export.h:124:2: note: in expansion of macro '__EXPORT_SYMBOL' __EXPORT_SYMBOL(sym, "") ^~~~~~~~~~~~~~~ >> lib/scatterlist.c:652:1: note: in expansion of macro 'EXPORT_SYMBOL' EXPORT_SYMBOL(__sg_page_iter_next); ^~~~~~~~~~~~~ include/linux/export.h:81:20: note: previous definition of '__kstrtab___sg_page_iter_next' was here static const char __kstrtab_##sym[] \ ^ include/linux/export.h:120:25: note: in expansion of macro '___EXPORT_SYMBOL' #define __EXPORT_SYMBOL ___EXPORT_SYMBOL ^~~~~~~~~~~~~~~~ include/linux/export.h:124:2: note: in expansion of macro '__EXPORT_SYMBOL' __EXPORT_SYMBOL(sym, "") ^~~~~~~~~~~~~~~ lib/scatterlist.c:626:1: note: in expansion of macro 'EXPORT_SYMBOL' EXPORT_SYMBOL(__sg_page_iter_next); ^~~~~~~~~~~~~ vim +/__kstrtab___sg_page_iter_next +81 include/linux/export.h 7290d580 Ard Biesheuvel 2018-08-21 76 f5016932 Paul Gortmaker 2011-05-23 77 /* For every exported symbol, place a struct in the __ksymtab section */ f2355416 Nicolas Pitre 2016-01-22 78 #define ___EXPORT_SYMBOL(sym, sec) \ f5016932 Paul Gortmaker 2011-05-23 79 extern typeof(sym) sym; \ f5016932 Paul Gortmaker 2011-05-23 80 __CRC_SYMBOL(sym, sec) \ f5016932 Paul Gortmaker 2011-05-23 @81 static const char __kstrtab_##sym[] \ 7290d580 Ard Biesheuvel 2018-08-21 82 __attribute__((section("__ksymtab_strings"), used, aligned(1))) \ 94e58e0a Masahiro Yamada 2018-05-09 83 = #sym; \ 7290d580 Ard Biesheuvel 2018-08-21 84 __KSYMTAB_ENTRY(sym, sec) f5016932 Paul Gortmaker 2011-05-23 85 :::::: The code at line 81 was first introduced by commit :::::: f50169324df4ad942e544386d136216c8617636a module.h: split out the EXPORT_SYMBOL into export.h :::::: TO: Paul Gortmaker <paul.gortma...@windriver.com> :::::: CC: Paul Gortmaker <paul.gortma...@windriver.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
