Hi Matthew, On Thu, Jan 3, 2019 at 12:41 AM Matthew Wilcox <wi...@infradead.org> wrote: > > When building with O= and C=1, this output looks weird: > > CC fs/file_table.o > CHECK ../fs/file_table.c > CC fs/open.o > CHECK ../fs/open.c > CC fs/super.o > CHECK ../fs/super.c > CC fs/read_write.o > CHECK ../fs/read_write.c > > Use $@ like CC instead of $< to produce the same output for both CHECK and CC. > > Signed-off-by: Matthew Wilcox <wi...@infradead.org> > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index fd03d60f6c5a..f36b03396d9a 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -74,10 +74,10 @@ __build: $(if $(KBUILD_BUILTIN),$(builtin-target) > $(lib-target) $(extra-y)) \ > > # Linus' kernel sanity checking tool > ifeq ($(KBUILD_CHECKSRC),1) > - quiet_cmd_checksrc = CHECK $< > + quiet_cmd_checksrc = CHECK $@ > cmd_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > else ifeq ($(KBUILD_CHECKSRC),2) > - quiet_cmd_force_checksrc = CHECK $< > + quiet_cmd_force_checksrc = CHECK $@ > cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $< > endif
IMHO, $@ is also a bit weird since Sparse does not produce objects at all. What I can suggest is like follows: quiet_cmd_checksrc = CHECK $(patsubst $(srctree)/%,%,$<) -- Best Regards Masahiro Yamada
