Looks fine - thanks.
On 2018-12-20 9:19 a.m., Thierry Reding wrote:
From: Thierry Reding <tred...@nvidia.com>
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.
Cc: Vikram Prakash <vikram.prak...@broadcom.com>
Cc: Scott Branden <scott.bran...@broadcom.com>
Cc: Florian Fainelli <f.faine...@gmail.com>
Cc: Ray Jui <ray....@broadcom.com>
Signed-off-by: Thierry Reding <tred...@nvidia.com>
Acked-by: Scott Branden <scott.bran...@broadcom.com>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c
b/drivers/mailbox/bcm-flexrm-mailbox.c
index d7a8ed7d8097..d713271ebf7c 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1665,7 +1665,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
mbox->controller.chans[index].con_priv = &mbox->rings[index];
/* Register mailbox controller */
- ret = mbox_controller_register(&mbox->controller);
+ ret = devm_mbox_controller_register(dev, &mbox->controller);
if (ret)
goto fail_free_debugfs_root;
@@ -1691,8 +1691,6 @@ static int flexrm_mbox_remove(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct flexrm_mbox *mbox = platform_get_drvdata(pdev);
- mbox_controller_unregister(&mbox->controller);
-
debugfs_remove_recursive(mbox->root);
platform_msi_domain_free_irqs(dev);
