-----Original Message-----
From: Greg KH <gre...@linuxfoundation.org>
Sent: 2018年12月19日 17:21
To: Xiaowei Bao <xiaowei....@nxp.com>
Cc: bhelg...@google.com; robh...@kernel.org; mark.rutl...@arm.com;
shawn...@kernel.org; Leo Li <leoyang...@nxp.com>; kis...@ti.com;
lorenzo.pieral...@arm.com; a...@arndb.de; M.h. Lian <minghuan.l...@nxp.com>;
Mingkai Hu <mingkai...@nxp.com>; Roy Zang <roy.z...@nxp.com>;
kstew...@linuxfoundation.org; cyrille.pitc...@free-electrons.com;
pombreda...@nexb.com; shawn....@rock-chips.com; niklas.cas...@axis.com;
linux-...@vger.kernel.org; devicet...@vger.kernel.org;
linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
linuxppc-...@lists.ozlabs.org
Subject: Re: [PATCHv3 4/4] misc: pci_endpoint_test: Add the layerscape EP
device support
On Mon, Dec 03, 2018 at 06:35:05PM +0800, Xiaowei Bao wrote:
> Add the layerscape EP device support in pci_endpoint_test driver.
>
> Signed-off-by: Xiaowei Bao <xiaowei....@nxp.com>
> ---
> v2:
> - no change
> v3:
> - no change
>
> drivers/misc/pci_endpoint_test.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c
> b/drivers/misc/pci_endpoint_test.c
> index 896e2df..744d10c 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -788,6 +788,8 @@ static void pci_endpoint_test_remove(struct
> pci_dev *pdev) static const struct pci_device_id pci_endpoint_test_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
> + /* 0x81c0: The device id of ls1046a in NXP. */
There is no need for a comment, just this line is fine:
> + { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) },
If you note, no other lines have comments.
If you want to say that this is a specific device, then use a #define with that
device name and then use that define here, like the PCI_DEVICE_ID_TI_DRA72x was
done.
thanks,
greg k-h
[Xiaowei Bao] Hi Greg, OK, I can remove the comments in the next version patch.
