Hi Peng, Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on next-20181214] [cannot apply to v4.20-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Peng-Hao/misc-pvpanic-return-0-for-empty-body-register-function/20181216-140504 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All errors (new ones prefixed by >>): drivers//misc/pvpanic.c: In function 'pvpanic_mmio_init': >> drivers//misc/pvpanic.c:237:28: error: 'pvpanic_pci_driver' undeclared >> (first use in this function); did you mean 'pvpanic_mmio_driver'? r2 = pci_register_driver(&pvpanic_pci_driver); ^~~~~~~~~~~~~~~~~~ pvpanic_mmio_driver drivers//misc/pvpanic.c:237:28: note: each undeclared identifier is reported only once for each function it appears in drivers//misc/pvpanic.c: In function 'pvpanic_mmio_exit': drivers//misc/pvpanic.c:251:25: error: 'pvpanic_pci_driver' undeclared (first use in this function); did you mean 'pvpanic_mmio_driver'? pci_unregister_driver(&pvpanic_pci_driver); ^~~~~~~~~~~~~~~~~~ pvpanic_mmio_driver vim +237 drivers//misc/pvpanic.c 228 229 static int __init pvpanic_mmio_init(void) 230 { 231 int r1, r2; 232 233 if (acpi_disabled) 234 r1 = platform_driver_register(&pvpanic_mmio_driver); 235 else 236 r1 = pvpanic_register_acpi_driver(); > 237 r2 = pci_register_driver(&pvpanic_pci_driver); 238 239 if (r1 && r2) /* all drivers register failed */ 240 return 1; 241 else 242 return 0; 243 } 244 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
