3.16.61-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Dan Carpenter <dan.carpen...@oracle.com>

commit 4051f5ebb11c6ef4b0d3eac2fbbd187c070656c5 upstream.

The "rc" variable is only initialized on the error path.  The caller
doesn't check the return but, if "rc" is non-zero, then this function is
basically a no-op.

Fixes: 3749c51ac6c1 ("PCI: Make current and maximum bus speeds part of the PCI 
core")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelg...@google.com>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 drivers/pci/hotplug/ibmphp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -397,7 +397,7 @@ static int get_adapter_present(struct ho
 
 static int get_max_bus_speed(struct slot *slot)
 {
-       int rc;
+       int rc = 0;
        u8 mode = 0;
        enum pci_bus_speed speed;
        struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;

Reply via email to