Peng,

On Thu, 1 Nov 2018, Peng Hao wrote:

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

Again:

 git grep 'This patch' Documentation/process/

This leads you to:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Documentation is there for a reason.

IOW, writing 'This patch does ....' is not the proper way for writing a
changelog. It's entirely clear that this is a patch. No need to mention
it. Imperative mood means something like this:

Replace the verbose license text with the matching SPDX license identifier.

Thanks,

        tglx

Reply via email to