Hi, On Fri, Sep 14, 2018 at 11:21:17AM +0200, Rafael J. Wysocki wrote: > On Tuesday, September 11, 2018 7:20:46 PM CEST Chen Yu wrote: > > From: Zhimin Gu <kookoo...@intel.com> > > > > Reduce the hibernation code duplication between x86-32 and x86-64 > > by extracting the common code into hibernate.c. > > > > No functional change. > > > > +#include "hibernate.c" > > I don't particularly like this. > > Why excatly do you need to include the C file here? > OK, I've removed this in a new version. > Also, the way this change is made makes it quite hard to review, as the > new code is not exactly the same as the code being removed, so it is > hard to say whether or not there really are no functional changes > as claimed. I've splitted the patch into several sub-patches and reorganized the code to make it more readable on a new version. > > This is sensitive code, mind you, and really hard to debug if anything goes > wrong. Please be super-careful about changing it. > Ok, will test on several platforms and send out the modification. Best, Yu > Thanks, > Rafael >
