Hi Thomas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Thomas-Gleixner/x86-mm-cpa-Improve-large-page-preservation-handling/20180915-062636
config: i386-randconfig-sb0-09151101 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   arch/x86/mm/pageattr.c: In function 'check_conflict':
>> arch/x86/mm/pageattr.c:419:2: warning: format '%lx' expects argument of type 
>> 'long unsigned int', but argument 7 has type 'pgprotval_t' [-Wformat=]
     pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent 
%016lx\n",
     ^
   arch/x86/mm/pageattr.c:419:2: warning: format '%lx' expects argument of type 
'long unsigned int', but argument 8 has type 'pgprotval_t' [-Wformat=]

vim +419 arch/x86/mm/pageattr.c

   406  
   407  static inline void check_conflict(int warnlvl, pgprot_t prot, 
pgprotval_t val,
   408                                    unsigned long start, unsigned long 
end,
   409                                    unsigned long pfn, const char *txt)
   410  {
   411          static const char *lvltxt[] = {
   412                  [CPA_PROTECT]   = "protect",
   413                  [CPA_DETECT]    = "detect",
   414          };
   415  
   416          if (warnlvl > cpa_warn_level || !conflicts(prot, val))
   417                  return;
   418  
 > 419          pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx 
 > prevent %016lx\n",
   420                  lvltxt[warnlvl], txt, start, end, pfn, 
pgprot_val(prot), val);
   421  }
   422  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to