Hi Thomas, I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core] [also build test WARNING on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Thomas-Gleixner/x86-mm-cpa-Improve-large-page-preservation-handling/20180915-062636 config: i386-randconfig-x076-201836 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/highmem.h:5, from arch/x86/mm/pageattr.c:5: arch/x86/mm/pageattr.c: In function 'check_conflict': >> include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of >> type 'long unsigned int', but argument 7 has type 'pgprotval_t {aka long >> long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ include/linux/printk.h:310:9: note: in expansion of macro 'KERN_WARNING' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~ include/linux/printk.h:311:17: note: in expansion of macro 'pr_warning' #define pr_warn pr_warning ^~~~~~~~~~ >> arch/x86/mm/pageattr.c:419:2: note: in expansion of macro 'pr_warn' pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ^~~~~~~ arch/x86/mm/pageattr.c:419:62: note: format string is defined here pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ~~~~~^ %016llx In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/highmem.h:5, from arch/x86/mm/pageattr.c:5: include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'pgprotval_t {aka long long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ include/linux/printk.h:310:9: note: in expansion of macro 'KERN_WARNING' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~ include/linux/printk.h:311:17: note: in expansion of macro 'pr_warning' #define pr_warn pr_warning ^~~~~~~~~~ >> arch/x86/mm/pageattr.c:419:2: note: in expansion of macro 'pr_warn' pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ^~~~~~~ arch/x86/mm/pageattr.c:419:77: note: format string is defined here pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ~~~~~^ %016llx -- In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/highmem.h:5, from arch/x86//mm/pageattr.c:5: arch/x86//mm/pageattr.c: In function 'check_conflict': >> include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of >> type 'long unsigned int', but argument 7 has type 'pgprotval_t {aka long >> long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ include/linux/printk.h:310:9: note: in expansion of macro 'KERN_WARNING' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~ include/linux/printk.h:311:17: note: in expansion of macro 'pr_warning' #define pr_warn pr_warning ^~~~~~~~~~ arch/x86//mm/pageattr.c:419:2: note: in expansion of macro 'pr_warn' pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ^~~~~~~ arch/x86//mm/pageattr.c:419:62: note: format string is defined here pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ~~~~~^ %016llx In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from include/linux/list.h:9, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/highmem.h:5, from arch/x86//mm/pageattr.c:5: include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'pgprotval_t {aka long long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:12:22: note: in expansion of macro 'KERN_SOH' #define KERN_WARNING KERN_SOH "4" /* warning conditions */ ^~~~~~~~ include/linux/printk.h:310:9: note: in expansion of macro 'KERN_WARNING' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~ include/linux/printk.h:311:17: note: in expansion of macro 'pr_warning' #define pr_warn pr_warning ^~~~~~~~~~ arch/x86//mm/pageattr.c:419:2: note: in expansion of macro 'pr_warn' pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ^~~~~~~ arch/x86//mm/pageattr.c:419:77: note: format string is defined here pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx prevent %016lx\n", ~~~~~^ %016llx vim +/pr_warn +419 arch/x86/mm/pageattr.c 406 407 static inline void check_conflict(int warnlvl, pgprot_t prot, pgprotval_t val, 408 unsigned long start, unsigned long end, 409 unsigned long pfn, const char *txt) 410 { 411 static const char *lvltxt[] = { 412 [CPA_PROTECT] = "protect", 413 [CPA_DETECT] = "detect", 414 }; 415 416 if (warnlvl > cpa_warn_level || !conflicts(prot, val)) 417 return; 418 > 419 pr_warn("CPA %8s %10s: 0x%016lx - 0x%016lx PFN %lx req %016lx > prevent %016lx\n", 420 lvltxt[warnlvl], txt, start, end, pfn, pgprot_val(prot), val); 421 } 422 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
