Commit 9c695203a7dd ("compiler-gcc.h: gcc-4.5 needs noclone
and noinline on __naked functions") added noinline and noclone
as a workaround for a gcc 4.5 bug, which was resolved in 4.6.0.Since now the minimum gcc supported version is 4.6, we can clean it up. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44290 and https://godbolt.org/z/h6NMIL Cc: Stefan Agner <ste...@agner.ch> Cc: Rasmus Villemoes <li...@rasmusvillemoes.dk> Cc: Eli Friedman <efrie...@codeaurora.org> Cc: Christopher Li <spa...@chrisli.org> Cc: Kees Cook <keesc...@chromium.org> Cc: Ingo Molnar <mi...@kernel.org> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Arnd Bergmann <a...@arndb.de> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Masahiro Yamada <yamada.masah...@socionext.com> Cc: Joe Perches <j...@perches.com> Cc: Dominique Martinet <asmad...@codewreck.org> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: linux-spa...@vger.kernel.org Reviewed-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulni...@google.com> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- include/linux/compiler-gcc.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 763bbad1e258..25d3dd6b2702 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -84,14 +84,8 @@ * to trace naked functions because then mcount is called without * stack and frame pointer being set up and there is no chance to * restore the lr register to the value before mcount was called. - * - * The asm() bodies of naked functions often depend on standard calling - * conventions, therefore they must be noinline and noclone. - * - * GCC 4.[56] currently fail to enforce this, so we must do so ourselves. - * See GCC PR44290. */ -#define __naked __attribute__((naked)) noinline __noclone notrace +#define __naked __attribute__((naked)) notrace #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) -- 2.17.1
