> -----Original Message----- > From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] > Sent: Tuesday, August 28, 2018 7:17 PM > To: Huang, Kai <kai.hu...@intel.com> > Cc: x...@kernel.org; platform-driver-...@vger.kernel.org; Hansen, Dave > <dave.han...@intel.com>; Christopherson, Sean J > <sean.j.christopher...@intel.com>; nhor...@redhat.com; > npmccal...@redhat.com; linux-...@vger.kernel.org; Kai Huang > <kai.hu...@linux.intel.com>; Thomas Gleixner <t...@linutronix.de>; Ingo > Molnar <mi...@redhat.com>; H. Peter Anvin <h...@zytor.com>; Borislav > Petkov <b...@suse.de>; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; > David Woodhouse <d...@amazon.co.uk>; open list:X86 ARCHITECTURE (32- > BIT AND 64-BIT) <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH v13 02/13] x86/cpufeature: Add SGX and SGX_LC CPU > features > > On Tue, Aug 28, 2018 at 12:07:41AM +0000, Huang, Kai wrote: > > > +#define X86_FEATURE_SGX_LC (16*32+30) /* supports SGX > launch > > > configuration */ > > > > Sorry if it was me who wrote the comment "SGX launch configuration". I > > think we should just use "SGX launch control". :) > > Not sure if we should change though. The former is more self-explaining, the > latter is "more official".
I'll let you decide. To me the comment should explain what does "LC" mean, and to me it means "launch control". :) Thanks, -Kai > > /Jarkko
