READ_BUF(8);
dummy = be32_to_cpup(p++);
dummy = be32_to_cpup(p++);
...
READ_BUF(4);
dummy = be32_to_cpup(p++);

Assigning value to "dummy" here, but that stored value
is overwritten before it can be used.
At the same time READ_BUF() will re-update the pointer p.

delete invalid assignment statements

Signed-off-by: nixiaoming <nixiaom...@huawei.com>
Signed-off-by: Chuck Lever <chuck.le...@oracle.com>
Signed-off-by: Trond Myklebust <tron...@hammerspace.com>
Signed-off-by: J. Bruce Fields <bfie...@fieldses.org>
---
 fs/nfsd/nfs4xdr.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index a96843c..e669e20 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1390,10 +1390,8 @@ nfsd4_decode_exchange_id(struct nfsd4_compoundargs *argp,
                        p += XDR_QUADLEN(dummy);
                }
 
-               /* ssp_window and ssp_num_gss_handles */
+               /* ignore ssp_window and ssp_num_gss_handles */
                READ_BUF(8);
-               dummy = be32_to_cpup(p++);
-               dummy = be32_to_cpup(p++);
                break;
        default:
                goto xdr_error;
-- 
2.10.1

Reply via email to