On Fri, 15 Jun 2007 10:50:12 +0200 Nicolas Ferre <[EMAIL PROTECTED]> wrote:
> From: Nicolas Ferre <[EMAIL PROTECTED]> > > Fixes STN LCD support for the atmel_lcdfb framebuffer driver. > > Signed-off-by: Nicolas Ferre <[EMAIL PROTECTED]> Looks correct to me. Although... > Index: b/drivers/video/Kconfig > =================================================================== > --- a/drivers/video/Kconfig 2007-05-14 11:02:16.000000000 +0200 > +++ b/drivers/video/Kconfig 2007-06-13 11:04:10.000000000 +0200 > @@ -701,6 +701,16 @@ > Say Y if you want to map Frame Buffer in internal SRAM. Say N if you > want > to let frame buffer in external SDRAM. > > +config FB_ATMEL_STN > + bool "Use a STN display with AT91/AT32 LCD Controller" > + depends on FB_ATMEL && ARCH_AT91SAM9261 > + default n > + help > + Say Y if you want to connect a STN LCD display to the AT91/AT32 LCD > + Controller. Say N if you want to connect a TFT. > + > + If unsure, say N. > + I don't think it's appropriate to include chip-specific options here. This option will not affect the driver at all, it will only affect the board-specific setup code, so IMO it should be under Platform-specific options or something like that. Also, the text says AT91/AT32 but it depends on one particular AT91 chip. I haven't had a chance to test it since I don't have any STN displays around, but I'll try forwarding it to someone who has. Haavard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
