Hi Simon, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.18-rc2 next-20180629] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Simon-Que/drivers-staging-Gasket-driver-framework-Apex-driver/20180630-080504 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from drivers/staging/gasket/gasket_core.c:16:0: drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_read_64': >> drivers/staging/gasket/gasket_core.h:658:9: error: implicit declaration of >> function 'readq'; did you mean 'readl'? >> [-Werror=implicit-function-declaration] return readq(&gasket_dev->bar_data[bar].virt_base[location]); ^~~~~ readl drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_write_64': drivers/staging/gasket/gasket_core.h:664:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] writeq(value, &dev->bar_data[bar].virt_base[location]); ^~~~~~ writel cc1: some warnings being treated as errors -- In file included from drivers/staging/gasket/gasket_ioctl.h:15:0, from drivers/staging/gasket/gasket_ioctl.c:13: drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_read_64': >> drivers/staging/gasket/gasket_core.h:658:9: error: implicit declaration of >> function 'readq'; did you mean 'readl'? >> [-Werror=implicit-function-declaration] return readq(&gasket_dev->bar_data[bar].virt_base[location]); ^~~~~ readl drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_write_64': drivers/staging/gasket/gasket_core.h:664:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] writeq(value, &dev->bar_data[bar].virt_base[location]); ^~~~~~ writel drivers/staging/gasket/gasket_ioctl.c: In function 'gasket_config_coherent_allocator': drivers/staging/gasket/gasket_ioctl.c:442:27: error: passing argument 3 of 'gasket_alloc_coherent_memory' from incompatible pointer type [-Werror=incompatible-pointer-types] gasket_dev, ibuf.size, &ibuf.dma_address, ^ In file included from drivers/staging/gasket/gasket_ioctl.c:18:0: drivers/staging/gasket/gasket_page_table.h:240:5: note: expected 'dma_addr_t * {aka unsigned int *}' but argument is of type 'u64 * {aka long long unsigned int *}' int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, uint64_t size, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from drivers/staging/gasket/gasket_page_table.h:26:0, from drivers/staging/gasket/gasket_page_table.c:41: drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_read_64': >> drivers/staging/gasket/gasket_core.h:658:9: error: implicit declaration of >> function 'readq'; did you mean 'readl'? >> [-Werror=implicit-function-declaration] return readq(&gasket_dev->bar_data[bar].virt_base[location]); ^~~~~ readl drivers/staging/gasket/gasket_core.h: In function 'gasket_dev_write_64': drivers/staging/gasket/gasket_core.h:664:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] writeq(value, &dev->bar_data[bar].virt_base[location]); ^~~~~~ writel drivers/staging/gasket/gasket_page_table.c: In function 'gasket_is_extended_dev_addr_bad': drivers/staging/gasket/gasket_page_table.c:1388:11: warning: right shift count >= width of type [-Wshift-count-overflow] if (addr >> (GASKET_EXTENDED_LVL0_WIDTH + GASKET_EXTENDED_LVL0_SHIFT)) { ^~ drivers/staging/gasket/gasket_page_table.c: In function 'gasket_alloc_coherent_memory': drivers/staging/gasket/gasket_page_table.c:1694:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] (u64)mem + j * PAGE_SIZE; ^ cc1: some warnings being treated as errors vim +658 drivers/staging/gasket/gasket_core.h 627 628 /* 629 * Memory management functions. These will likely be spun off into their own 630 * file in the future. 631 */ 632 633 /* Unmaps the specified mappable region from a VMA. */ 634 int gasket_mm_unmap_region( 635 const struct gasket_dev *gasket_dev, struct vm_area_struct *vma, 636 const struct gasket_mappable_region *map_region); 637 638 /* 639 * Get the ioctl permissions callback. 640 * @gasket_dev: Gasket device structure. 641 */ 642 gasket_ioctl_permissions_cb_t gasket_get_ioctl_permissions_cb( 643 struct gasket_dev *gasket_dev); 644 645 /** 646 * Lookup a name by number in a num_name table. 647 * @num: Number to lookup. 648 * @table: Array of num_name structures, the table for the lookup. 649 * 650 */ 651 const char *gasket_num_name_lookup( 652 uint num, const struct gasket_num_name *table); 653 654 /* Handy inlines */ 655 static inline ulong gasket_dev_read_64( 656 struct gasket_dev *gasket_dev, int bar, ulong location) 657 { > 658 return readq(&gasket_dev->bar_data[bar].virt_base[location]); 659 } 660 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
