On 06/29/18 17:02, Simon Que wrote: > diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig > new file mode 100644 > index 000000000000..3465e8510fc2 > --- /dev/null > +++ b/drivers/staging/gasket/Kconfig > @@ -0,0 +1,23 @@ > +menu "Gasket devices" > + > +config STAGING_GASKET_FRAMEWORK > + tristate "Gasket framework" > + depends on PCI > + help > + This framework supports Gasket-compatible devices, such as Apex. > + It is required for either of those modules.
Either of what modules? Maybe "for any of those modules." ? Also, Kconfig help text indentation is (from Documentation/process/coding-style.rst): Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. so one tab + 2 spaces, please, above and below here. > + > + To compile this driver as a module, choose M here. The module > + will be called "gasket". > + > +config STAGING_APEX_DRIVER > + tristate "Apex Driver" > + depends on STAGING_GASKET_FRAMEWORK > + help > + This driver supports the Apex device. Say Y if you want to > + include this driver in the kernel. > + > + To compile this driver as a module, choose M here. The module > + will be called "apex". > + > +endmenu -- ~Randy
